Issue-423: Crash when editing device dataitem in DeviceModel - #424
Merged
Conversation
…ions map. Updated CircularBuffer::updateDataItems() to remove orphans from m_slidingBuffer
wsobel
requested changes
Mar 19, 2024
Member
|
We can't erase from the circular buffer since the positions are computed using the sequence numbers. it is better to leave holes. When we get observations from the circular buffer, it skips orphaned observations. The checkpoint code looks correct. Did you write a test to verify the changes? |
wsobel
changed the title
…instead of deleting them.
Contributor
Author
|
I updated CircularBuffer::updateDataItems() to skip orphaned dataItems instead of deleting them from the sliding buffer. Checkpoint::updateDataItems() still deletes orphaned observations.
I didn't write a test to verify the changes. I can take a peek at existing unit tests to see if there is something I can modify to test the agent when data items are added / removed or their IDs are changed. |
Member
|
Thanks a lot. I will review changes later today. - W
|
wsobel
approved these changes
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#423
Updated Checkpoint::updateDataItems() to remove orphans from observations map. Updated CircularBuffer::updateDataItems() to remove orphans from m_slidingBuffer